iOS9.3 patch #9
Open
iOS9.3 patch #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanb93
requested changes
Dec 15, 2016
| } | ||
| } | ||
| if(contains) { | ||
| UIAlertController* alert=[UIAlertController alertControllerWithTitle:[NSString stringWithFormat:@"%@ IS uninstalling",[app displayName]] message:@"Please WAIT A SEC" preferredStyle:UIAlertControllerStyleAlert]; |
There was a problem hiding this comment.
Lets make this text a little bit more professional.
UIAlertController* alert=[UIAlertController alertControllerWithTitle:[NSString stringWithFormat:@"%@ is uninstalling",[app displayName]] message:@"Please wait. This should only take a few seconds." preferredStyle:UIAlertControllerStyleAlert];
There was a problem hiding this comment.
In addition to this, we should probably be using localized strings here.
| @@ -397,11 +463,17 @@ static void uninstallClickedForIcon(SBIcon *self) { | |||
| } | |||
|
|
|||
| -(NSString *)uninstallAlertTitle { | |||
| return [NSString stringWithFormat:SBLocalizedString(@"UNINSTALL_ICON_TITLE"), | |||
| %log; | |||
| [[self application] displayName]]; | ||
| } | ||
|
|
||
| -(NSString *)uninstallAlertBody { | ||
| %log; |
| @@ -427,11 +499,17 @@ static void uninstallClickedForIcon(SBIcon *self) { | |||
| } | |||
|
|
|||
| -(NSString *)uninstallAlertConfirmTitle { | |||
| return SBLocalizedString(@"UNINSTALL_ICON_CONFIRM"); | |||
| %log; | |||
| } | ||
|
|
||
| -(NSString *)uninstallAlertCancelTitle { | ||
| return SBLocalizedString(@"UNINSTALL_ICON_CANCEL"); | ||
| %log; |
| @@ -1,4 +1,4 @@ | |||
| CyDelete | |||
| ========= | |||
|
|
|||
| The original mobile substrate CyDelete tweak created by @DHowett updated for iOS 7 and 8. | |||
| The original mobile substrate CyDelete tweak created by @DHowett and ported to iOS7/8 by Ryan Burke updated for iOS 9. | |||
There was a problem hiding this comment.
A mobile substrate tweak to uninstall applications from the homescreen that have been installed using Cydia.
Contributors
CyDelete - Dustin Howett
CyDelete 7 & 8 - Ryan Burke
CyDelete 9 - Pal Lockhart
|
In fact seems this dialog not need to show in latest build. Previous I’m using `apt-get remove then uicache` way, and it disappears too late( almost 10 secs after clicking) so I added the dialog. Then I changed to the new way, first unregister app to hide the icon, then apt-get remove in background; this way the dialog seems unnecessary, since user will have no time on click it again, but I forgot to remove the code. Let me modify it tomorrow :P too late in me time region, almost sun rising, too easy to introduce bug.
… 在 2016年12月16日，上午5:05，Ryan Burke ***@***.***> 写道：
@ryanb93 commented on this pull request.
In CyDelete.xm <#9>:
> SBApplication *app = [icon application];
id pkgName = ownerForSBApplication(app);
if(pkgName != [NSNull null]) {
uninstallClickedForIcon(icon);
}
- %orig;
+ if(cydelete_IOSVersionAbove92() && [[iconPackagesDict allKeys] containsObject:[app bundleIdentifier]]) {
+ //new mechanism: iOS 9.2 above will not automatically trigger uninstall, we've to call it manually
+ BOOL contains = NO;
+ for(CDUninstallDpkgOperation *operation in [uninstallQueue operations]){
+ if([operation.package isEqualToString:[app bundleIdentifier]]){
+ contains = YES;
+ break;
+ }
+ }
+ if(contains) {
+ UIAlertController* alert=[UIAlertController alertControllerWithTitle:[NSString stringWithFormat:@"%@ IS uninstalling",[app displayName]] message:@"Please WAIT A SEC" preferredStyle:UIAlertControllerStyleAlert];
In addition to this, we should probably be using localized strings here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#9>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADjbsCB1lJs-nQTT9ht4RkdOtULpFt1ks5rIauvgaJpZM4LOjHZ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds iOS 9.3 support, should also works for iOS 7/8/9.0-9.1 ( not tested due to lack of device ), not sure for iOS 9.2. Previous design only for iOS9, so pangu8 protection was replaced to pangu 9.2-9.3 protection.